Addition to convert commondata new to old#112
Open
ecole41 wants to merge 4 commits intocommondata_converter_new_to_oldfrom
Open
Addition to convert commondata new to old#112ecole41 wants to merge 4 commits intocommondata_converter_new_to_oldfrom
ecole41 wants to merge 4 commits intocommondata_converter_new_to_oldfrom
Conversation
ecole41
changed the base branch from
main
to
commondata_converter_new_to_old
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR edits the convert commondata new to old function to allow for kinematics which are string form, these are converted to zeros. Also this PR 'pops' the stat uncertainty from the
uncertainty_valuessuch that the stat uncertainty is not double counted