Open
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (98.21%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 94.96% 95.20% +0.23%
==========================================
Files 31 32 +1
Lines 1649 1667 +18
==========================================
+ Hits 1566 1587 +21
+ Misses 83 80 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comane
reviewed
Mar 23, 2026
59f1d0c to
1afebf6
Compare
LucaMantani
commented
Mar 26, 2026
| self, | ||
| pred_func: Callable[[jnp.ndarray, Any], jnp.ndarray], | ||
| pdf_model, | ||
| extra_param_names: list[str] = (), |
Member
Author
There was a problem hiding this comment.
Suggested change
| extra_param_names: list[str] = (), | |
| extra_param_names: list[str] = [], |
| by the forward map via ``self.n_pdf_params``. | ||
| """ | ||
|
|
||
| def __init__(self, pdf_model, extra_param_names: list[str] = ()): |
Member
Author
There was a problem hiding this comment.
Suggested change
| def __init__(self, pdf_model, extra_param_names: list[str] = ()): | |
| def __init__(self, pdf_model, extra_param_names: list[str] = []): |
| return self._pred_func(pdf, fk_tables), pdf | ||
|
|
||
|
|
||
| def forward_map(_pred_data, pdf_model, extra_param_names=()): |
Member
Author
There was a problem hiding this comment.
Suggested change
| def forward_map(_pred_data, pdf_model, extra_param_names=()): | |
| def forward_map(_pred_data, pdf_model, extra_param_names=[]): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at separating the definition of the forward map from the pdf_model, granting us further flexibility to implement generalisations such as the addition of nuisance parameters or eft Wilson coefficients.
The main changes are: