Added make_replicas from Validphys - #429
Conversation
7b2cdf4 to
eed39cd
Compare
comane
left a comment
comane
left a comment
There was a problem hiding this comment.
Thanks Ella, the PR looks good.
Apart from the two minor comments I left, I think that it would be good if you could add a couple of lines of tests (to the already existing tests) so as to cover the extra lines that you added.
| central_values = [pseudodata_central_covmat_index.central_values] | ||
| covmat = pseudodata_central_covmat_index.covmat |
There was a problem hiding this comment.
Could you add a comment that explains why they need to be a list?
| seed = replica_mcseed(replica_index, mcseed, genrep=True) | ||
|
|
There was a problem hiding this comment.
what does this function do and why do we need it?
If it is in order to get the same seed as n3fit then please add a comment that specifies this
There was a problem hiding this comment.
Yes, it is to get the same seed as n3fit. I have added a comment to explain this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 95.00% 95.02% +0.01%
==========================================
Files 31 31
Lines 1642 1648 +6
==========================================
+ Hits 1560 1566 +6
Misses 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, thanks for taking care of this! Feel free to merge if you're happy with it too |
comane
changed the title
2 participants
This branch alters the
mc_pseudodatafunction so that it uses the validphys functionmake_replicasto produce pseudodata. This is compatible with themake_replicas_colibribranch of NNPDF. Amcseedwill need to be defined in the runcard.Testing is still needed before merging.