Open
Conversation
… (explicit node) and renamed the covariance matrix explicit node to general_covariance_matrix
…aced it directly with central_covmat_index
…eportengine node with parent general_covariance_matrix
…yesian and analytical
…hi2 to compute chi2 with gemv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation of this PR:
NOTES:
Whitening should give a computational advantage since when dealing with a triangular matrix we only need to compute half of the flops that we have to compute with a dense matrix.
A small (~10-15%) computational improvement is observed but not a factor of 2. This might be because the actual metric which counts more than flops is arithmetic intensity.
Maybe we should also whiten the FK tables??