Skip to content

Fix bayes prior bug#444

Open
vschutze-alt wants to merge 9 commits intomainfrom
fix_bayes_prior_bug
Open

Fix bayes prior bug#444
vschutze-alt wants to merge 9 commits intomainfrom
fix_bayes_prior_bug

Conversation

@vschutze-alt
Copy link
Copy Markdown
Collaborator

@vschutze-alt vschutze-alt commented Mar 26, 2026

This PR fixes a bug in the uniform prior, which if given max and min for all parameters as floats would generate the wrong size samples from the sample method. It needs to be an array of values for the distribution to know the correct parameter size.

It also adds the n_parameters attribute to the pdf model base class, which is currently used by blackjax and is in general useful to have.

vschutze-alt and others added 2 commits March 26, 2026 16:24
Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (47ea395) to head (ce6ab9a).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   94.96%   95.03%   +0.06%     
==========================================
  Files          31       31              
  Lines        1649     1652       +3     
==========================================
+ Hits         1566     1570       +4     
+ Misses         83       82       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants