Add new makeflow_type: lstbin_single_baseline#155
Merged
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new makeflow type, "lstbin_single_baseline", designed to handle LST-stacking files with a single baseline configuration.
- Introduces a new function build_lstbin_single_baseline_makeflow_from_config in mf_tools.py to create makeflow files using baseline strings.
- Adds new tests in tests/test_mf_tools.py to verify the makeflow construction and wrapper script generation for the new type.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hera_opm/tests/test_mf_tools.py | New tests ensuring proper behavior of the lstbin_single_baseline type. |
| hera_opm/mf_tools.py | Added new branch in build_makeflow_from_config and a dedicated function for lstbin_single_baseline. |
for more information, see https://pre-commit.ci
up hera_cal dependency for tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 98.88% 98.89% +0.01%
==========================================
Files 4 4
Lines 716 725 +9
==========================================
+ Hits 708 717 +9
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3.9 is nearly at end-of-life
plaplant
approved these changes
Jul 7, 2025
|
|
||
|
|
||
| @pytest.fixture() | ||
| def tmp_cfg_dir(tmp_path: Path) -> Path: |
Member
There was a problem hiding this comment.
Very clever, this is a nice way to make the testing layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new makeflow_type,
lstbin_single_baseline, designed for LST-stacking files that have one baseline (generally for all 2 or 4 pols) for all times on a given JD. This is a thin wrapper around theanalysistype, using baseline strings like1_2instead of JD strings as "obsids"... which seems to work just fine.The advantage of this, as opposed to modifying the lstbin type is that this currently supports workflows with multiple actions (which I think I'll need). Also, single-baseline LST stacking is fundamentally more similar to analysis types, where existing files are the base object on which we'd like to parallelize, rather than an abstract set of LSTs inferred from the data and the configuration files.
This PR requires HERA-Team/hera_cal#1005 to be merged first.