Fix fftvis beamidx - #415
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 93.63% 93.65% +0.02%
==========================================
Files 25 25
Lines 3345 3358 +13
Branches 555 555
==========================================
+ Hits 3132 3145 +13
Misses 112 112
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tyler-a-cox
approved these changes
Jun 30, 2026
tyler-a-cox
left a comment
Contributor
There was a problem hiding this comment.
This is looking good to me! We should probably make a note to fix the polarized=False case at some point though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the
beam_idxparameter through to FFTVis.Also adds a test that compares against pyuvsim using multiple beams. Note that for some reason if
polarized=Falsethis test fails. I made #414 to track this bug.