Skip to content

Fix fftvis beamidx - #415

Merged
steven-murray merged 6 commits into
mainfrom
fix-fftvis-beamidx
Jul 1, 2026
Merged

Fix fftvis beamidx#415
steven-murray merged 6 commits into
mainfrom
fix-fftvis-beamidx

Conversation

@steven-murray

Copy link
Copy Markdown
Contributor

Pass the beam_idx parameter through to FFTVis.

Also adds a test that compares against pyuvsim using multiple beams. Note that for some reason if polarized=False this test fails. I made #414 to track this bug.

@steven-murray steven-murray self-assigned this Jun 30, 2026
@steven-murray steven-murray added the type: bug Something isn't working label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (b36e109) to head (b614ace).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   93.63%   93.65%   +0.02%     
==========================================
  Files          25       25              
  Lines        3345     3358      +13     
  Branches      555      555              
==========================================
+ Hits         3132     3145      +13     
  Misses        112      112              
  Partials      101      101              
Flag Coverage Δ
unittests 93.65% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tyler-a-cox tyler-a-cox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! We should probably make a note to fix the polarized=False case at some point though

@steven-murray
steven-murray merged commit 41125be into main Jul 1, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants