Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
…kelihood into update-infrastructure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 93.10% 94.11% +1.01%
==========================================
Files 5 5
Lines 406 408 +2
==========================================
+ Hits 378 384 +6
+ Misses 28 24 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@adeliegorce though the warnings tests are failing, this is mostly due to hera_pspec, not pspec-likelihood. I have added some warnings tests over there (HERA-Team/hera_pspec#433) which should help us track these warnings over time, but they are just warnings, not true test failures. |
There was a problem hiding this comment.
Thank you for all these changes @steven-murray! I just have two comments (see above). We should probably wait for hera_pspec PR #433 to be done before merging this one, to make sure the tests run OK.
adeliegorce
left a comment
There was a problem hiding this comment.
PR looks good; only small issue is the warning tests failing, mostly because of hera_pspec. This will need to be fixed in the future but is unrelated to this PR. PR approved.
Updates the instrastructure somewhat to keep things modern. Tests fail due to some parts of pspec not being up to date. I will go and fix those at some point....