Skip to content

Update infrastructure#76

Merged
steven-murray merged 15 commits intomainfrom
update-infrastructure
Apr 8, 2026
Merged

Update infrastructure#76
steven-murray merged 15 commits intomainfrom
update-infrastructure

Conversation

@steven-murray
Copy link
Copy Markdown
Collaborator

Updates the instrastructure somewhat to keep things modern. Tests fail due to some parts of pspec not being up to date. I will go and fix those at some point....

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.11%. Comparing base (298f06b) to head (d864f77).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/pspec_likelihood/likelihood.py 92.68% 3 Missing ⚠️
...c/pspec_likelihood/arbitrary_linear_systematics.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   93.10%   94.11%   +1.01%     
==========================================
  Files           5        5              
  Lines         406      408       +2     
==========================================
+ Hits          378      384       +6     
+ Misses         28       24       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steven-murray
Copy link
Copy Markdown
Collaborator Author

@adeliegorce though the warnings tests are failing, this is mostly due to hera_pspec, not pspec-likelihood. I have added some warnings tests over there (HERA-Team/hera_pspec#433) which should help us track these warnings over time, but they are just warnings, not true test failures.

Copy link
Copy Markdown
Contributor

@adeliegorce adeliegorce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all these changes @steven-murray! I just have two comments (see above). We should probably wait for hera_pspec PR #433 to be done before merging this one, to make sure the tests run OK.

Copy link
Copy Markdown
Contributor

@adeliegorce adeliegorce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good; only small issue is the warning tests failing, mostly because of hera_pspec. This will need to be fixed in the future but is unrelated to this PR. PR approved.

@steven-murray steven-murray merged commit 0baa655 into main Apr 8, 2026
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants