[TTAHUB-4152] Consider Findings done after Monitoring Goal closure

[hardwarehuman]

Description of change

This now updates both the citations service and the Monitoring goal creation process to follow all the additional logic we know about:

• Considering Findings closed/complete/done for the purposes of AR and Monitoring Goal creation if a Monitoring Goal has been closed for the relevant grant since the last time a monitoring review was delivered containing that Finding.
• Using the MonitoringFindingHistory.determination for the latest review as the findingType, unless null, in which case it defaults back to MonitoringFindings.findingType
• Considering Findings 'Active' if they have a status of 'Active' or 'Elevated Deficiency' OR if the latest review for the Finding is not yet delivered

This is considerably more comprehensive than the original Jira/PR so needs to be re-reviewed.

How to test

This is not an easy one to test separately. On way to see it working because the AOC ED80AFF2-78CF-40C0-BBC4-9C5258DC22C8 isn't present in the open_citations CTE and so won't trigger a Goal opening.

I would expect it to open goals for:

 grantId |  rname   | grant num
---------+----------+------------
   12656 | 257754FU | 02HP000452
   15492 | 257827FU | 04CH012635
   15902 | 251575FU | 06CH012933
   12632 | 251012FU | 07CH011961
   15790 | 250220FU | 90CI010161

Issue(s)

• https://jira.acf.gov/browse/TTAHUB-4152

Checklists

Every PR

• Meets issue criteria
• JIRA ticket status updated
• Code is meaningfully tested
• Meets accessibility standards (WCAG 2.1 Levels A, AA)
• API Documentation updated
• Boundary diagram updated
• Logical Data Model updated
• Architectural Decision Records written for major infrastructure decisions
• UI review complete
• QA review complete

Before merge to main

• OHS demo complete
• Ready to create production PR

Production Deploy

• PR created as Draft
• Staging smoke test completed
• PR transitioned to Open
• Reviewer added (after transitioning to Open to ensure Slack notifications trigger)
  • Sequence: Draft PR → Smoke test → Open PR → Add reviewer
  • Confirm that Slack notification was sent after reviewer was added

After merge/deploy

• Update JIRA ticket status

[kryswisnaskas]

Thanks for the update to the monitoring goal logic and documentation!

A quick check on grants_needing_goal. Shouldn't we also link the open_citations in the logic there?

[hardwarehuman]

Thanks for the update to the monitoring goal logic and documentation!

A quick check on grants_needing_goal. Shouldn't we also link the open_citations in the logic there?

Whoooops! Somewhere along the way there was a significant reversion. I'll fix that and repush

[kryswisnaskas]

Looks good! 👍

[hardwarehuman]

The changes on this are pretty large so they need rereview

[thewatermethod]

this isn't used later, is it?

[hardwarehuman]

Ugggh it isn't but it probably should have been in ordered_citation_reviews. I changed the citations ordered_citation_reviews to match what was in createMonitoringGoals but using all_reviews would be faster. Trying to keep these things consistent is a giant PITA and I can't wait to replace most of this with the fact tables. It's probably fast enough this way but it would be faster if I used the more refined version here which is closer to what's in the recipient spotlight.

[thewatermethod]

I certainly defer to your expertise, but if it's just a performance issue, the query ran pretty quick on prod data, so if it's accurate both ways it might be good to just wait for the fact

[thewatermethod]

Ran the script, runs without error. Data modifications look to be correct.