Conversation
Handle blank --config-json safely, auto-start bots on websocket connect, guard botId route param usage in UI, and add regression tests for CLI/router/web param normalization.`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens TutorBot and CLI behavior across three failure modes that surfaced in local UI usage on Windows:
--config-jsonis present but arrives as blank/whitespace by normalizing and treating it as{}before JSON parsing.botIdis normalized safely and no API/WS calls are attempted withundefined.Regression coverage was added for CLI parsing, TutorBot WS startup behavior, and web route-param normalization.
Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstestscliChecklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Tests run locally:
uv run pytest tests/cli/test_common.py tests/api/test_tutorbot_router.pynode --test "web/tests/route-params.test.ts"Key files touched:
deeptutor_cli/common.pydeeptutor/api/routers/tutorbot.pyweb/app/(workspace)/agents/[botId]/chat/page.tsxweb/lib/route-params.tstests/cli/test_common.pytests/api/test_tutorbot_router.pyweb/tests/route-params.test.ts