fix(cache): partition KG answers by chunk selection - #3877
Open
Shizoqua wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partition KG answer-cache entries by chunk-selection configuration.
Problem
Changing
related_chunk_numberorkg_chunk_pick_methodcan change the retrieved context while reusing an answer cached under the previous configuration.Changes
Include both settings in the KG answer-cache key and recorded cache metadata.
Testing
47 relevant query-cache tests passed. Ruff, pre-commit and
git diff --checkpassed.Compatibility and Risk
Low risk. Existing KG cache entries using the previous key will be bypassed.
Related Issue
No related issue.