forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 132
Enable Ovis2.5 #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SupreetSinghPalne
wants to merge
13
commits into
v1.23.0_next
Choose a base branch
from
spalne/port_ovis
base: v1.23.0_next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable Ovis2.5 #2013
+2,364
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Essential Elements of an Effective PR Description Checklist - [ ] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". - [ ] The test plan, such as providing test command. - [ ] The test results, such as pasting the results comparison before and after, or e2e results ## Purpose ## Test Plan ## Test Result <!--- pyml disable-next-line no-emphasis-as-heading --> --------- Co-authored-by: Christopher Manteuffel <[email protected]>
From #1940 --------- Co-authored-by: Christopher Manteuffel <[email protected]> Co-authored-by: Jianhong-Zhang <[email protected]>
1. fix pixel_values dimension 2. fix typo for Ovis 3. remove log for padding
Confirming all the code changes related to HPU Graph are in. |
@SupreetSinghPalne this pr is missing #2015 |
michalkuligowski
requested changes
Oct 14, 2025
@@ -0,0 +1 @@ | |||
ovis2_5-9b.yaml No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix precommit issues
Is this still planed for 1.23?
c583284
to
6185a0f
Compare
6185a0f
to
27b84a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist