Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

chezzoba
Copy link

The curriculum is now completely revamped and ready for testing on the guinea pigs we call team28!

For a summary of the revamped React curriculum and lesson plans view this planning document.

@chezzoba chezzoba assigned te-online and chezzoba and unassigned te-online and chezzoba Aug 22, 2024
@chezzoba chezzoba requested review from a team and te-online and removed request for a team August 22, 2024 20:45
@chezzoba chezzoba removed the request for review from te-online August 23, 2024 07:08
Copy link

@adamblanchard adamblanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuinely amazing! Hope it worked well at the weekend too. I guess things will be tweaked over the following weeks but here's a few comments and additional points here:

  1. It looks like there are now some unused assets we could remove too? Check each of the assets folders, think there is some in each one
  2. Should we have a "homework.md" in each week for consistency? Or remove it from react1 week1 too?
  3. Is "react2/readme.md" week 1 topic still accurate? Or should we replace "render props" with "nextjs router"? 🤔

@chezzoba
Copy link
Author

Genuinely amazing! Hope it worked well at the weekend too. I guess things will be tweaked over the following weeks but here's a few comments and additional points here:

  1. It looks like there are now some unused assets we could remove too? Check each of the assets folders, think there is some in each one
  2. Should we have a "homework.md" in each week for consistency? Or remove it from react1 week1 too?
  3. Is "react2/readme.md" week 1 topic still accurate? Or should we replace "render props" with "nextjs router"? 🤔

Super nice! Good catches and thank you! Yes, this weekend was amazing, thanks to our superstars @bhas and @ddobby94. I addressed these issues.

  1. That is very true, I deleted them now.
  2. I removed the one in React 1 Week 1. We now have links in the React 1 readme for that.
  3. It is not, and will be addressed - maybe in another branch?

@adamblanchard
Copy link

@chezzoba Fab! I'll approve it for merge, if you can take care of point 3 soon so we don't leave the official docs out of date for too long.

Huge thanks again! Excited to hear how it goes over the next weeks 🙌

P.s. If you don't have permission to merge it, just tell me when and I can do it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants