This repository was archived by the owner on Oct 14, 2025. It is now read-only.
React1 week2/soheib #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desafree
reviewed
Apr 10, 2025
| <NavItem title={navbarItems[0].title} link={navbarItems[0].link} isActive={navbarItems[0].link === currentPath} /> | ||
| <NavItem title={navbarItems[1].title} link={navbarItems[1].link} isActive={navbarItems[1].link === currentPath} /> | ||
| <NavItem title={navbarItems[2].title} link={navbarItems[2].link} isActive={navbarItems[2].link === currentPath} /> | ||
|
|
There was a problem hiding this comment.
Here instead of calling NavItem multiple times you could rely on map to make it cleaner and more modular :)
desafree
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Tbh here I would separate the icons into different files and maybe store them inside an Icon folder to make it cleaner. Nice job using an SVG btw!
desafree
reviewed
Apr 10, 2025
| isSelected={isPlanetSelected} | ||
| onAddOrRemovePlanet={onAddOrRemovePlanet} | ||
| ></PlanetCard> | ||
| <PlanetCard |
There was a problem hiding this comment.
This is a nice opportunity for using map! If you store the information of the planets into an array of object you can make this more modular and clean!
|
Good job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you in advance dear Mentor