java: add class and date tools to enable juicy Velocity vulnerabilities [issue 4] #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes template-injection-playground/java more vulnerable to more SSTI attacks. Written using aider (an AI coding tool) as follows: 1. told aider to create a commandline-only demo of Velocity that took a template on stdin and wrote its expansion to stdout 2. iterated until that could handle $date and $class 3. backported the interesting bits to template-injection-playground Addresses Hackmanit#4 Given that I'm not a Java developer anymore, this deserves a bit more review than a non-vibe-coded change, but it does look nicely minimal.
dkegel-fastly
changed the title
Collaborator
|
Another great PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes template-injection-playground/java vulnerable to more SSTI attacks.
Written using aider (an AI coding tool) as follows:
Addresses #4
Given that I'm not a Java developer anymore, this deserves a bit more review than a non-vibe-coded change, but it does look nicely minimal.