Closed
Conversation
briaguya0
reviewed
May 14, 2026
serprex
reviewed
May 16, 2026
added 3 commits
May 17, 2026 09:47
…raw" This reverts commit ac569ba. # Conflicts: # soh/src/overlays/actors/ovl_En_Dnt_Nomal/z_en_dnt_nomal.c
serprex
approved these changes
May 17, 2026
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2796.
Despite the
interpolationlabel on the issue, this is not a frame interpolation bug. The flash occurs at original frame rates as well -- it's an actor initialization issue where the draw function is enabled before all draw data is ready. This bug also exists on original hardware, but is likely masked by the original asynchronous DMA.En_Dnt_Nomalbriefly renders its flower display list at the world origin during spawn. The actor's lifecycle has a gap between its draw andflowerPosinitialization. BetweenEnDntNomal_WaitForObjectandEnDntNomal_SetFlower,flowerPosis zero-initialized frommemsetinActor_Spawn. BothEnDntNomal_DrawTargetScrubandEnDntNomal_DrawStageScrubuseflowerPoswithMTXMODE_NEWto position the flower independently of the actor, so the flower renders at(0, 0, 0)untilSetFlowercorrects it.21 actors share the same deferred-draw pattern (draw function set in an
Object_IsLoadedcallback rather thanInit). I audited all of them individually andEn_Dnt_Nomalis the only one affected. The other 20 either draw atactor.world.pos(always valid from spawn) or initialize all draw data in the same update call where the draw function is enabled.