Skip to content

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 28, 2026

Motivation

The existing x-nc-dump CLI command dumps NC data from a local storage. This PR updates this command so it supports dumping data from a remote peer, via P2P, with the --address arg. New args --until-complete, --until-block, --until-height, and --until-common are also added.

Acceptance Criteria

  • Small change in HathorManager: move Twisted shutdown event registration from __init__ to start.
  • Move dumping logic from nc_dump CLI to new abstract class NCDumper.
  • Create concrete LocalNCDumper and RemoteNCDumper, via P2P.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

🐰 Bencher Report

Branchfeat/remote-nc-dump
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(-1.12%)Baseline: 1.71 m
1.54 m
(91.02%)
2.06 m
(82.40%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/remote-nc-dump branch from f9bc2f6 to 0c11108 Compare January 28, 2026 01:44
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 41.13712% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (b619928) to head (a116e88).

Files with missing lines Patch % Lines
hathor/nanocontracts/nc_dump/remote_nc_dumper.py 39.87% 98 Missing ⚠️
hathor/nanocontracts/nc_dump/nc_dumper.py 37.27% 69 Missing ⚠️
hathor/nanocontracts/nc_dump/local_nc_dumper.py 57.89% 8 Missing ⚠️
hathor/manager.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   85.73%   85.39%   -0.35%     
==========================================
  Files         439      442       +3     
  Lines       33767    34060     +293     
  Branches     5277     5317      +40     
==========================================
+ Hits        28951    29084     +133     
- Misses       3803     3965     +162     
+ Partials     1013     1011       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the feat/remote-nc-dump branch from 0c11108 to 6c04bfb Compare January 28, 2026 02:47
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jan 28, 2026
@glevco glevco force-pushed the feat/remote-nc-dump branch 2 times, most recently from b6df852 to bcd03ee Compare January 28, 2026 19:34
@glevco glevco force-pushed the feat/remote-nc-dump branch from bcd03ee to a116e88 Compare January 28, 2026 22:11
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review (WIP)

Development

Successfully merging this pull request may close these issues.

3 participants