feat(nano): add ability to dump remote nc storage #1584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing
x-nc-dumpCLI command dumps NC data from a local storage. This PR updates this command so it supports dumping data from a remote peer, via P2P, with the--addressarg. New args--until-complete,--until-block,--until-height, and--until-commonare also added.Acceptance Criteria
HathorManager: move Twisted shutdown event registration from__init__tostart.nc_dumpCLI to new abstract classNCDumper.LocalNCDumperandRemoteNCDumper, via P2P.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged