add hat tree linking language + minor fixes#100
Open
more-reese wants to merge 2 commits into
Open
Conversation
more-reese
commented
Feb 24, 2023
more-reese
commented
- Update language in Hat Tree linking section to reflect David's feedback in moreReese<>Hats telegram group (sent 23 February 2023)
- Fix broken internal links to section headers
davehrlichman
requested changes
Mar 3, 2023
| # Hat Tree linking | ||
| This powerful feature lets you graft two trees together, by linking the Top Hat from one tree to a hat from another tree. | ||
|
|
||
| When this happens, as seen in the diagram, the level 2 hat from Tree 1 becomes the admin for the Top Hat of tree 2, and therefore the Top Hat of Tree 2 effectively becomes a level 3 hat in Tree 1. The previous Top Hat from the now nonexistent Tree 2 will then hold the same properties as as any other hat in Tree 1, with one distinction: the Top Hat and its child hats can be unlinked from Tree 1 at any point in the future, thereby returning back to the initial state of having two separate hats trees. |
Contributor
There was a problem hiding this comment.
Suggested change
| When this happens, as seen in the diagram, the level 2 hat from Tree 1 becomes the admin for the Top Hat of tree 2, and therefore the Top Hat of Tree 2 effectively becomes a level 3 hat in Tree 1. The previous Top Hat from the now nonexistent Tree 2 will then hold the same properties as as any other hat in Tree 1, with one distinction: the Top Hat and its child hats can be unlinked from Tree 1 at any point in the future, thereby returning back to the initial state of having two separate hats trees. |
|
|
||
| <img src=./assets/hatTreeLinking2.png width="600" height="350"> | ||
|
|
||
| If approved, Hat Tree 2 links, or "grafts", to Hat Tree 1. The approving hat becomes the admin hat the Top Hat from Hat Tree 2. |
Contributor
There was a problem hiding this comment.
Suggested change
| If approved, Hat Tree 2 links, or "grafts", to Hat Tree 1. The approving hat becomes the admin hat the Top Hat from Hat Tree 2. | |
| If approved, Hat Tree 2 links, or "grafts", to Hat Tree 1. The approving hat becomes the admin hat of the Top Hat from Hat Tree 2. |
|
|
||
| <img src=./assets/hatTreeLinking3.png width="600" height="400"> | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
The Top Hat from Tree 2, along with its associated branch, can be unlinked from Tree 1 at any point in the future, thereby returning back to the initial state of having two separate hats trees.
| You can mint a Top Hat with the `mintTopHat` function, which creates and mints a hat that is its own admin*, i.e. a `topHat`. | ||
|
|
||
|
|
||
| _*Note: New functionality is coming soon that will enable Top Hats and their associated trees to be linked and unlinked to other existing Hats trees, by changing the admin of a Top Hat._ |
Contributor
There was a problem hiding this comment.
Delete "*Note: New functionality is coming soon that will enable Top Hats and their associated trees to be linked and unlinked to other existing Hats trees, by changing the admin of a Top Hat."
| *_These characteristics are new in v1_ | ||
|
|
||
|
|
||
| You can mint a Top Hat with the `mintTopHat` function, which creates and mints a hat that is its own admin*, i.e. a `topHat`. |
Contributor
There was a problem hiding this comment.
Delete the * after "admin"
|
|
||
| <span style="color: red; font-weight: bold"> DRAFT </span>Last updated: 9 February | ||
|
|
||
| _Please add comments as you use this draft guide for anything that you feel could be clarified, improved, or added — thank you!_ |
| ## Step 3: Paste `id` in the `viewHat` function on the `Read Contract` page | ||
|
|
||
| # Eligibility and Toggle | ||
| Eligibility and toggle are dynamic and extensible modules that have the authority to rule on a hat wearer’s eligibility and standing (eligibility module) and switch the status of a hat (toggle module). |
Contributor
There was a problem hiding this comment.
Add "on and off" just after "switch the status of a hat"
|
|
||
| The eligibility and toggle design space is huge. Future guides will dive deeper and explore more complex implementations of eligibility and toggle logic. This guide focuses on a simple implementation: setting eligibility and toggle as an address that determines eligibility and toggle for a given hat. This involves two contracts: `changeHatEligibility` and `changeHatToggle`. | ||
|
|
||
| By default, we recommend setting the eligibility and toggle addresses to the DAO's address (or the address wearing the Top Hat), so that the DAO retains the power to revoke hats and turn them off by vote, until more structure is put in place." might also be good to mention this when creating the hat in the first place. |
Contributor
There was a problem hiding this comment.
Delete "might also be good to mention this when creating the hat in the first place."
| </td> | ||
| </tr> | ||
| </table> | ||
|
|
Contributor
There was a problem hiding this comment.
Add "By default, we recommend setting the eligibility and toggle addresses to the DAO's address (or the address wearing the Top Hat), so that the DAO retains the power to revoke hats and turn them off by vote, until more structure is put in place."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.