Skip to content

FlxPoint: Add setXY, deprecate one-arg set(x) #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

FlxPoint: Add setXY, deprecate one-arg set(x) #3490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 71 additions & 14 deletions flixel/math/FlxPoint.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,20 +301,48 @@ import openfl.geom.Point;
{
this = FlxPoint.get(x, y);
}


/**
* Set the coordinates of this point object.
*
* @param n The X and Y coordinate of the point in space.
*/
public inline function setXY(n:Float):FlxBasePoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't function return FlxPoint instead of FlxBasePoint?

Copy link

@BernardoGP4504 BernardoGP4504 Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't function return FlxPoint instead of FlxBasePoint?

Both are the same, FlxBasePoint is the underlying type of FlxPoint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't function return FlxPoint instead of FlxBasePoint?

Both are the same, FlxBasePoint is the underlying type of FlxPoint

It still matters, this is a copy paste error, I think it's already fixed locally, but I'll check

{
return set(n, n);
}


/**
* Set the coordinates of this point object.
*
* @param x The X-coordinate of the point in space.
* @param y The Y-coordinate of the point in space.
*/
public inline function set(x:Float = 0, y:Float = 0):FlxPoint
overload public inline extern function set(x:Float, y:Float):FlxPoint
{
this.x = x;
this.y = y;
return this;
return this.set(x, y);
}


/**
* Sets the x coordinate of this point and zeroes the y coordinate.
*
* @param x The X-coordinate of the point in space.
*/
@:deprecated("set(n) is deprecated, use the two-arged set(n, 0), instead")
overload public inline extern function set(x:Float):FlxPoint
{
return set(x, 0);
}

/**
* Set the coordinates of this point to zero.
*/
overload public inline extern function set():FlxPoint
{
return set(0, 0);
}

/**
* Adds to the coordinates of this point.
*
Expand Down Expand Up @@ -1577,18 +1605,45 @@ class FlxBasePoint implements IFlxPooled
{
set(x, y);
}


/**
* Necessary for FlxCallbackPoint.
*/
function setHelper(x:Float, y:Float):FlxBasePoint
{
this.x = x;
this.y = y;
return this;
}

/**
* Set the coordinates of this point object.
*
* @param x The X-coordinate of the point in space.
* @param y The Y-coordinate of the point in space.
*/
public function set(x:Float = 0, y:Float = 0):FlxBasePoint
overload public inline extern function set(x:Float, y:Float):FlxBasePoint
{
this.x = x;
this.y = y;
return this;
return setHelper(x, y);
}

/**
* Sets the x coordinate of this point and zeroes the y coordinate.
*
* @param x The X-coordinate of the point in space.
*/
@:deprecated("set(n) is deprecated, use the two-arged set(n, 0), instead")
overload public inline extern function set(x:Float):FlxBasePoint
{
return set(x, 0);
}

/**
* Set the coordinates of this point to zero.
*/
overload public inline extern function set():FlxBasePoint
{
return set(0, 0);
}

/**
Expand Down Expand Up @@ -1690,7 +1745,9 @@ abstract FlxReadOnlyPoint(FlxPoint) from FlxPoint
inline function get_degrees():Float return this.degrees;

// hide underlying mutators
inline function set(x = 0, y = 0):FlxReadOnlyPoint return this.set(x, y);
overload inline extern function set(x, y):FlxReadOnlyPoint return this.set(x, y);
overload inline extern function set(x):FlxReadOnlyPoint return this.set(x);
overload inline extern function set():FlxReadOnlyPoint return this.set();
inline function add(x = 0, y = 0):FlxReadOnlyPoint return this.add(x, y);
inline function addPoint(point):FlxReadOnlyPoint return this.add(point);
inline function subtract(x = 0, y = 0):FlxReadOnlyPoint return this.subtract(x, y);
Expand Down Expand Up @@ -1753,9 +1810,9 @@ class FlxCallbackPoint extends FlxBasePoint
}
}

override public function set(x:Float = 0, y:Float = 0):FlxCallbackPoint
override function setHelper(x:Float, y:Float):FlxCallbackPoint
{
super.set(x, y);
super.setHelper(x, y);
if (_setXYCallback != null)
_setXYCallback(this);
return this;
Expand Down