Skip to content

[cppia] Fix *= with boxed numbers in jit #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[cppia] Fix *= with boxed numbers in jit #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786f155
[cppia] Fix *= with boxed numbers in jit
tobil4sk Sep 17, 2025
2274eb8
[tests] Add regression test for cppia jit *= bug
tobil4sk Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/hx/cppia/Cppia.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3667,8 +3667,10 @@ void genSetter(CppiaCompiler *compiler, const JitVal &ioValue, ExprType exprType
compiler->mult(ioValue, sJitTempF0, ioValue,true);
else
{
compiler->mult(sJitTempF0, sJitTempF0, ioValue,true);
compiler->convert(sJitTempF0, etFloat, ioValue, exprType );
JitTemp fval(compiler, jtFloat);
compiler->convert(ioValue, exprType, fval, etFloat);
compiler->mult(sJitTempF0, sJitTempF0, fval, true);
compiler->convert(sJitTempF0, etFloat, ioValue, exprType);
}
}
break;
Expand Down
8 changes: 8 additions & 0 deletions test/cppia/Client.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ class Client
default:
}

// regression test for #926
var x:Dynamic = 3;
x *= 5;
if (x != 15) {
Common.status = 'Failed regression test for #926. x: $x';
return;
}

final extending = new ClientExtendedExtendedRoot();

extending.addValue();
Expand Down
Loading