Conversation
This reverts commit 37192642e58e9f8dc90a3babae96a8889066d788. The change was an attempt to fix the following issue reported by a user: I (10:37:32.526) WILLOW/AUDIO: AUDIO_REC_WAKEUP_END I (10:37:32.542) WILLOW/AUDIO: WIS HTTP client HTTP_STREAM_POST_REQUEST, write end chunked marker E (10:37:34.547) transport_base: esp_tls_conn_read error, errno=No more processes I (10:37:34.548) WILLOW/AUDIO: WIS HTTP client HTTP_STREAM_FINISH_REQUEST E (10:37:34.562) WILLOW/AUDIO: WIS response took longer than 2000ms, connection aborted Unfortunately this change didn't fix the bug. The problem is that something changed between the ESP components in 0.3.* and 0.4.*, and this particular problem happens only when using WIS over TLS. As the change doesn't fix anything, revert it.
stintel
force-pushed
the
http_connect_timeout
branch
from
9dde447 to
6765fb9
Compare
Something between ESP-IDF v5.1.1 and 5.3.3 changed that causes the 10s timeout we set in the HTTP_STREAM_POST_REQUEST callback to be ignored when using HTTPS. Due to this, people with slower WIS cannot use Willow 0.4 anymore. Set the timeout to 10s in HTTP_STREAM_PRE_REQUEST to not use the ESP-ADF http_stream hardcoded default of 30s. If WIS is not running, or the user configured a wrong IP or port, the transport layer detects the problem early anyway.
stintel
force-pushed
the
http_connect_timeout
branch
from
6765fb9 to
9694d78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something between ESP-IDF v5.1.1 and 5.3.3 changed that causes the 10s timeout we set in the HTTP_STREAM_POST_REQUEST callback to be ignored when using HTTPS. Due to this, people with slower WIS cannot use Willow 0.4 anymore. Set the timeout to 10s in HTTP_STREAM_PRE_REQUEST to not use the ESP-ADF http_stream hardcoded default of 30s.
If WIS is not running, or the user configured a wrong IP or port, the transport layer detects the problem early anyway.