Conversation
jfmath04
requested changes
Apr 1, 2026
Contributor
jfmath04
left a comment
jfmath04
left a comment
There was a problem hiding this comment.
WOW this looks amazing!!!!! Good work!!
Just some small things:
- Be sure to run Prettier:
yarn formatandyarn format:fix - Can we add a rounded border around the view?
- Try adding the gray for the heading and left side, and the alternating rows like in the Figma
- Replace the hex codes with references to colors in the theme (import the theme in)
| fontSize: 11, | ||
| fontWeight: 500, | ||
| letterSpacing: "0.04em", | ||
| color: isToday ? "#1a8a72" : "#6b7280", |
jfmath04
requested changes
Apr 3, 2026
Contributor
jfmath04
left a comment
jfmath04
left a comment
There was a problem hiding this comment.
Looks good visually! Just replace the theme colors with a theme import and use those colors. Once you're done, you can remove the test page.
Comment on lines
+10
to
+17
| const TEAL = '#1EA7AE'; | ||
| const HEADER_GRAY = '#EBEBEB'; | ||
| const ROW_GRAY = '#F7F7F7'; | ||
| const BORDER = '#D2D2D2'; | ||
| const GRAY_500 = '#808080'; | ||
| const GRAY_800 = '#1A1A1A'; | ||
| const WHITE = '#FFFFFF'; | ||
| const RED = '#D14343'; |
Contributor
There was a problem hiding this comment.
We can do import { useTheme } from "evergreen-ui" and then use the colors in the theme so we don't have to copy over the values!
frontend/app/week-view-test/page.tsx
Outdated
Contributor
There was a problem hiding this comment.
Once you're done with testing, we can delete this file and folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes