DEV-612 - Created the get_notifications function#91
Merged
issacli-0821 merged 6 commits intopreviewfrom Mar 28, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
issacli-0821
changed the title
issacli-0821
requested changes
Mar 25, 2026
| class NotificationView(APIView): | ||
| """Handle collection operations for notifications.""" | ||
|
|
||
| def get_notifications(self, user_id) -> Response: |
Contributor
There was a problem hiding this comment.
This just needs to be a standalone function and not a class
| """Handle collection operations for notifications.""" | ||
|
|
||
| def get_notifications(self, user_id) -> Response: | ||
| """Get all notifications for a given user.""" |
Contributor
There was a problem hiding this comment.
I also updated the urls.py, so now the user_id is not passed in directly. Instead, it can be obtained by doing request.user.id
| class NotificationView(APIView): | ||
| """Handle collection operations for notifications.""" | ||
|
|
||
| def get_notifications(self, user_id) -> Response: |
Contributor
There was a problem hiding this comment.
The function should have request as a param
issacli-0821
approved these changes
Mar 28, 2026
mar-crespo
pushed a commit
that referenced
this pull request
Apr 4, 2026
* Created the get_notifications function * Made get_notifications into a standalone function and changed to request.user.id * hopefully this fixes merge conflicts * Lint notification_views --------- Co-authored-by: issacli-0821 <tl1719@princeton.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes