Skip to content

DEV-451: update-implementation-for-check-independent-work-required#442

Open
gyang148 wants to merge 3 commits intopreviewfrom
dev451_check_iw_req
Open

DEV-451: update-implementation-for-check-independent-work-required#442
gyang148 wants to merge 3 commits intopreviewfrom
dev451_check_iw_req

Conversation

@gyang148
Copy link
Copy Markdown
Contributor

References

Proposed Changes

  • Updated check_independent_work_required to read from db the new iw_required_ field.
  • A future modification perhaps is to get all the iw_required fields regarding all the minors and certificates in two queries in some separate function and storing it somehow (and essentially remove the function altogether) to reduce the number of queries we make? Let me know :)
  • was not able to test just yet, because the yaml files have not been pushed yet.

@linear
Copy link
Copy Markdown

linear bot commented Mar 17, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plan Ready Ready Preview, Comment Mar 19, 2026 1:34am

Request Review

@gyang148 gyang148 changed the base branch from main to preview March 17, 2026 06:32
prereq_status_dict[minor_code] = _check_prereq_satisfied(req)
iw_status_dict[minor_code] = _check_independent_work_required(req)
incomplete_subreqs_dict[minor_code] = _get_incomplete_subrequirements(req)
iw_status_dict[minor_code] = _check_independent_work_required(minor_code,"Minor")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the table names (Minor or Certificate) enums

@issacli-0821
Copy link
Copy Markdown
Collaborator

Looks good! Need to resolve the merge conflicts though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants