Skip to content

DEV-702 Allow calendars with unassigned P99 time to be exported #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannahchoi05 wants to merge 1 commit into
base: preview
Choose a base branch
from
+10 −4
Open

DEV-702 Allow calendars with unassigned P99 time to be exported #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions frontend/app/calendar/CalendarSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,18 +229,24 @@ export const CalendarSearch: FC = () => {
// All courses in the selected semester
const currentSemesterCourses = getSelectedCourses(termFilter);

// We need to make sure user doesn't have any unsettled courses
const hasMeetingTime = (course: (typeof currentSemesterCourses)[number]) => {
const meetings = course.section?.class_meetings;
return meetings && meetings.length > 0 && meetings[0]?.days && meetings[0].days.trim() !== '';
};

// We need to make sure user doesn't have any unsettled courses that have an assigned time
const hasUnselectedRequired = currentSemesterCourses.some(
(course) => course.isActive && course.needsChoice && !course.isChosen
(course) =>
course.isActive && course.needsChoice && !course.isChosen && hasMeetingTime(course)
);

if (hasUnselectedRequired) {
return null;
}

// Filter out sections that are active
// Filter out sections that are active and have an assigned meeting time
const class_sections = currentSemesterCourses.filter(
(course) => course.isChosen || !course.needsChoice
(course) => (course.isChosen || !course.needsChoice) && hasMeetingTime(course)
);

const seenSectionIds = new Set<number>();
Expand Down