Initial support for adding new rows to a page - #220
Conversation
|
have been taking a look and playing with this (combined with the |
|
I got a simple mp3 exporter working. The database and audio files are read by the pioneer cdj-350 correctly. Take a look if you have time https://github.com/acrilique/rekordcrate/tree/pdb-from-scratch |
Nice! I think we should get some stuff merged so we can build on top of each others' work more easily. |
|
This PR is highly related to #173 |
| trait PageHeapObject { | ||
| type Args<'a>; | ||
|
|
||
| /// Required page heap space in bytes to store the object. | ||
| fn heap_bytes_required(&self, args: Self::Args<'_>) -> u16; | ||
| } |
There was a problem hiding this comment.
whats your opinion on writing a custom derive for this?
There was a problem hiding this comment.
It would be useful to reduce boilerplate for sure but adds an extra crate that we would need to version and track. I think that it's probably not worth the overhead for now.
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
This Lgtm. @acrilique or @Holzhaus, do you have any opinion on this?
acrilique
left a comment
acrilique
left a comment
There was a problem hiding this comment.
It also looks good to me. Have been playing w this one (as I said in previous comments) and thus am excited to get it merged.
Holzhaus
left a comment
Holzhaus
left a comment
There was a problem hiding this comment.
Looks good, thank you very much. Excited for this one!
4 participants
No description provided.