Add public read-only accessors for PDB row fields#236
Open
cjchanh wants to merge 1 commit intoHolzhaus:mainfrom
Open
Add public read-only accessors for PDB row fields#236cjchanh wants to merge 1 commit intoHolzhaus:mainfrom
cjchanh wants to merge 1 commit intoHolzhaus:mainfrom
Conversation
Adds read-only public accessors for private PDB row fields on Album, Artist, Artwork, Genre, Key, Label, and Track. Does not change binary layout, parser behavior, write behavior, or existing public types. Every new public method has a one-line doc comment and returns either a copyable ID/scalar field or a borrowed &DeviceSQLString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds read-only public accessors for private PDB row fields on
Album,Artist,Artwork,Genre,Key,Label, andTrack.This does not change binary layout, parser behavior, write behavior, or existing public types.
Motivation
Downstream read-only tools need access to parsed rekordbox PDB metadata without reimplementing the parser or depending on incompatible alternatives. The currently parsed row structs contain the data, but most useful fields are private.
The concrete downstream use case is resolving track metadata from rekordbox device exports while keeping USB/library handling read-only and non-mutating.
Changes
Album:id,artist_id,nameArtist:id,nameArtwork:id,pathGenre:id,nameKey:id,nameLabel:id,nameTrack:id,artist_id,album_id,genre_id,key_id,artwork_id,sample_rate,bitrate,tempo_centi_bpm,play_count,year,duration_seconds,rating,title,filename,file_path,comment,analyze_pathEvery new public method has a one-line doc comment and returns either a copyable ID/scalar field or a borrowed
&DeviceSQLString.Validation
Validated against current
Holzhaus/rekordcratemainat:Checks:
cargo build: PASScargo test: PASSPatch file BLAKE3:
Notes
This PR intentionally excludes downstream-only warning overrides used by a vendored release-mode verification copy. This PR contains only the public accessor patch.
This patch was regenerated against current upstream
main; it is not the archivedrekordcrate-0.3.0patch from the downstream extraction package.