feat(scratchnode): lock NodeBench private handoff#404
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Augment PR SummarySummary: Locks the ScratchNode Live (public) ↔ NodeBench AI (private) boundary and adds deterministic handoff URLs from the ScratchNode v5 proto into NodeBench private event notebooks. Changes:
Technical Notes: Handoff URLs carry 🤖 Was this summary useful? React with 👍 or 👎 |
| var WORKSPACE_BASE_URL = (function() { | ||
| try { | ||
| var h = location.hostname || ''; | ||
| var proto = (location.protocol === 'http:' || location.protocol === 'https:') ? location.protocol : 'https:'; |
There was a problem hiding this comment.
public/proto/home-v5.html:1134 — WORKSPACE_BASE_URL inherits location.protocol when running on nodebenchai.com, which can produce http://... handoff/sign-in URLs if the page is served over HTTP. That can break auth redirects and undermines the intended transport guarantees for the private workspace boundary.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } | ||
| closeSheet(); | ||
| toast('Magic link sent to ' + email, 'Check your inbox.'); | ||
| toast('Magic link sent to ' + email, 'Check your inbox. Return target: NodeBench event notebook.'); |
There was a problem hiding this comment.
public/proto/home-v5.html:2413 — sendMagicLink() doesn’t actually attach or compute a return URL, but the toast claims the return target is the NodeBench event notebook. This could mislead users if the magic-link flow returns them elsewhere (or remains a stub).
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Superseded by CI-compliant branch feat/scratchnode-nodebench-handoff with the same commit; codex/* branch prefix is rejected by the Branch name gate. |
Summary
Verification
Known existing harness gap