Open
Conversation
…essorEndpoint contract
andreanistico
approved these changes
Mar 27, 2026
saratnt
requested changes
Mar 30, 2026
| requestType: requestType | ||
| }); | ||
| _requestIdByOrder[_tail] = requestId; | ||
| appLockedFunds[applicationId] += msg.value; |
Contributor
There was a problem hiding this comment.
It is actually appLockedFunds[applicationId] += depositAmount; msg.value contains also the fee, that are not locked inside any app, but they are just kept in the contract balance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Jira task: https://horizenlabs.atlassian.net/browse/HZN-2834
Per-app fund isolation for
ProcessorEndpoint. A newappLockedFundsmapping tracks how much currency each application has deposited (credited onsubmitRequest/submitDeployRequest, debited onstateUpdate).The per-app solvency check fires before the existing global balance check, preventing one app from draining another app's funds during withdrawals or refunds.
Note: The global check is retained as defense-in-depth.
Includes comprehensive Hardhat and Go integration tests covering cross-app isolation, accumulation, boundary conditions, and mixed error/success paths.