feat: Update Views API for PR #164#6657
Open
Suruthi-G-K wants to merge 2 commits intoIBM-Cloud:masterfrom
Open
feat: Update Views API for PR #164#6657Suruthi-G-K wants to merge 2 commits intoIBM-Cloud:masterfrom
Suruthi-G-K wants to merge 2 commits intoIBM-Cloud:masterfrom
Conversation
- syntax_type now required with enum validation - Added tier field with enum validation
Suruthi-G-K
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
kavya498
requested changes
Feb 10, 2026
| @@ -75,27 +77,31 @@ Nested schema for **filters**: | |||
| * Constraints: The maximum length is `4096` items. The minimum length is `1` item. | |||
| Nested schema for **filters**: | |||
| * `name` - (Required, String) Filter name. | |||
| * Constraints: The maximum length is `4096` characters. The minimum length is `1` character. The value must match regular expression `^[\\p{L}\\p{N}\\p{P}\\p{Z}\\p{S}\\p{M}]+$`. | |||
| * Constraints: The maximum length is `4096` characters. The minimum length is `1` character. The value must match regular expression `/^[\\p{L}\\p{N}\\p{P}\\p{Z}\\p{S}\\p{M}]+$/`. | |||
| * `selected_values` - (Required, Map) Filter selected values. | |||
Collaborator
There was a problem hiding this comment.
I think this is optional according to new API spec.
kavya498
reviewed
Feb 12, 2026
| return diag.FromErr(err) | ||
| } | ||
| replaceViewOptions.SetSearchQuery(searchQueryModel) | ||
| searchQuery, err := ResourceIbmLogsViewMapToApisViewsV1SearchQuery(d.Get("search_query.0").(map[string]interface{})) |
Collaborator
There was a problem hiding this comment.
Is search query optional?
If so, lets please have the if condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the IBM Cloud Logs Views API to implement changes from dragonlog-openapi PR #164.
Changes
API Schema Updates (PR #164)
lucene,dataprime)all_logs,all_logs_templates,priority_insights,priority_insights_templates)Community Note
Relates OR Closes #0000
Output from acceptance testing: