Skip to content
This repository was archived by the owner on May 27, 2021. It is now read-only.

DO NOT MERGE#36

Open
rhagarty wants to merge 2 commits intomasterfrom
dev7
Open

DO NOT MERGE#36
rhagarty wants to merge 2 commits intomasterfrom
dev7

Conversation

@rhagarty
Copy link
Contributor

@rhagarty rhagarty commented Jun 5, 2018

  • update to new VisRec V3
  • get VR key from VCAP services
  • new plan name in manifest.yaml

Copy link
Member

@scottdangelo scottdangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the debug?

} catch (e) {
reject(e);
}
log.debug('calling visualRecognition detectFaces', params);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really. was hoping it would help isolate what call was generating the error

} catch (e) {
reject(e);
}
log.debug('calling visualRecognition recoognizeText', params);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed these debug calls in new commit

@rhagarty
Copy link
Contributor Author

rhagarty commented Jun 5, 2018

will fix lint issues shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants