Minor update to logic in Degeneracy Hunter #1591
Conversation
adowling2
requested review from
agarciadiego,
dallan-keylogic,
lbianchi-lbl,
dangunter and
bpaul4
as code owners
|
Sorry, I was not careful with my branches. This also includes the simple edit in #1590 |
|
This is ready to review. |
There was a problem hiding this comment.
Hi @adowling2, thanks for opening this. To resolve the test failures, I believe you just need to update the expected string object. Try adding print(stream.get_value()) right before the failing assert check, it should print the correct string for you in the error log, then update expected and remove the print statement.
| ) | ||
|
|
||
| stream.write(f"{TAB}Smallest Singular Value {e}:\n\n") | ||
| stream.write(f"{TAB}Smallest Singular Value {e} ({self.s[e-1]:.3e}):\n\n") |
There was a problem hiding this comment.
Thank you for this change---I was going to make it myself at some point.
| f"constraint {cons.name}. This probably indicates the constraint" | ||
| " is not a major component of an IDS." | ||
| ) | ||
| return None |
There was a problem hiding this comment.
return None works just like return. Since this statement is at the end of the function, no return statement is needed at all. You don't need to actually change anything here (unless Pylint says to), but I thought I'd point it out.
|
@adowling2, any progress on this (given the above suggestions)? |
|
@adowling2 Will you have the chance to address these comments anytime soon? |
|
This is back on my radar now that the semester is over. |
|
@adowling2 is this now back off your radar? |
|
@adowling2, now moving to Nov... |
Fixes
Summary/Motivation:
Changes proposed in this PR:
ValueErrorwith an appropriate print statement.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: