Helmholtz ammonia

[StephenBurroughs]

Fixes

Adds Helmholtz formulation for ammonia based on SKehui Gao, Jiangtao Wu, Ian H. Bell, Allan H. Harvey, and Eric W. Lemmon (2023): " A Reference Equation of State with an Associating Term for Thermodynamic Properties of Ammonia" along with with thermal conductivity and viscosity rules

Also, fixes an existing issue where the CO2 was using a surface tension correlation value for water - Mulero, A., I. Cachadina, Parra, M., Recommended Correlations for the Surface Tension of Common Fluids, J. Phys. Chem. Ref. Data 41, 043105, (2012).

Summary/Motivation:

We needed to add Ammonia into the Ahuora Platform, seemed only right to also integrate it upstream!

Changes proposed in this PR:

• Added Ammonia parameters for general Helmholtz
• Added new formulations for Helmholtz ideal and residual expressions

Comparison between T/S and P/H plots generated within this property package and those from CoolProp:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[dallan-keylogic]

Do you test the expression for thermal conductivity anywhere?

[bpaul4]

A couple comments on the documentation, plus I second @dallan-keylogic's request to ensure everything is tested.

[StephenBurroughs]

Do you test the expression for thermal conductivity anywhere?

I did not as I could not find existing tests to follow for this within the package. This is also true for viscosity and surface tension. If there are some existing tests, please point me toward them and I will replicate them for Ammonia. Otherwise, if need be we can create some tests but it might be a month or so until we get around to it.

[dallan-keylogic]

Do you test the expression for thermal conductivity anywhere?

I did not as I could not find existing tests to follow for this within the package. This is also true for viscosity and surface tension. If there are some existing tests, please point me toward them and I will replicate them for Ammonia. Otherwise, if need be we can create some tests but it might be a month or so until we get around to it.

It would be wonderful if you could create some tests. As we saw with CO2 using the surface tension value for water, an error can stay undetected for a long time unless we're explicitly testing against experimental values. But since you're contributing this voluntarily, it's not required to be merged.

We could just merge this and open an issue to write these tests. @agarciadiego , what do you think?

[dallan-keylogic]

@StephenBurroughs , could you please merge main into your branch? That will fix the failing CoolProp test.