-
Notifications
You must be signed in to change notification settings - Fork 276
Additional SOC Updates #1667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dallan-keylogic
wants to merge
9
commits into
IDAES:main
Choose a base branch
from
dallan-keylogic:soc_final_changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Additional SOC Updates #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
+ Coverage 77.06% 77.10% +0.03%
==========================================
Files 395 395
Lines 62761 62904 +143
Branches 10233 10276 +43
==========================================
+ Hits 48369 48502 +133
- Misses 11981 11991 +10
Partials 2411 2411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These failing tests are expected and are fixed in IDAES/examples#150 (which will be merged after this PR is merged into IDAES). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
CrossFlowHeatExchanger1D
to enable use of Lagrange-Legendre collocation without structural singularity. (The methods here should be ported to PyomoDAE eventually, see 1D Heat Exchanger needs Upwinding #1581)Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: