Skip to content

Conversation

dallan-keylogic
Copy link
Contributor

Summary/Motivation:

  • Adds the option to create heat loss terms on the SOC in order to realistically model a hot idle state.
  • Adds a term to modify the exchange current densities at the triple phase boundary to use as a hook for degradation modeling
  • Adds a method to the CrossFlowHeatExchanger1D to enable use of Lagrange-Legendre collocation without structural singularity. (The methods here should be ported to PyomoDAE eventually, see 1D Heat Exchanger needs Upwinding #1581)

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 90.85366% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.10%. Comparing base (00c61dc) to head (bcb384e).

Files with missing lines Patch % Lines
..._models/soc_submodels/solid_oxide_module_simple.py 74.19% 6 Missing and 2 partials ⚠️
idaes/core/base/control_volume1d.py 66.66% 2 Missing and 1 partial ⚠️
idaes/models/unit_models/heat_exchanger_1D.py 80.00% 1 Missing and 1 partial ⚠️
...tion/unit_models/soc_submodels/solid_oxide_cell.py 96.22% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   77.06%   77.10%   +0.03%     
==========================================
  Files         395      395              
  Lines       62761    62904     +143     
  Branches    10233    10276      +43     
==========================================
+ Hits        48369    48502     +133     
- Misses      11981    11991      +10     
  Partials     2411     2411              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Sep 19, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Sep 19, 2025
@dallan-keylogic
Copy link
Contributor Author

dallan-keylogic commented Sep 22, 2025

These failing tests are expected and are fixed in IDAES/examples#150 (which will be merged after this PR is merged into IDAES).

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants