-
Notifications
You must be signed in to change notification settings - Fork 276
Add testing 3.13 python to workflow #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 77.07% 77.06% -0.01%
==========================================
Files 395 395
Lines 62759 62759
Branches 10234 10234
==========================================
- Hits 48369 48366 -3
- Misses 11978 11982 +4
+ Partials 2412 2411 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for integration tests
setup.py
Outdated
# FIXME this must be changed to the PyPI distribution for the release | ||
# "idaes-ui", | ||
"idaes-ui @ git+https://github.com/IDAES/idaes-ui@main", | ||
"idaes-ui @ git+https://github.com/sufikaur/idaes-ui@main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be changed back to IDAES
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is going to be a new idaes ui release and yes this will be changed back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was approved so integration tests could be tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sufikaur you can also add the CI:run-integration
label to PRs to force the integration tests to run without needing a reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I don't think I have permission to add labels. @blnicho @ksbeattie, are either of you able to? I ran integration tests by merging this into my fork.
Please add 3.13 as a supported version in the README also: https://github.com/IDAES/idaes-pse/blob/main/README.md?plain=1#L88 We should also check the docs to see if the Python versions we support are explicitly mentioned. |
Fixes
Issue 1668
Summary/Motivation:
Catch up to current python releases. 3.14 will be released soon so understanding is supporting 3.13 is possible with the current state.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
Notes
current version of greenlet is 3.0.3. thus, the dependency is breaking for 3.13 tests (support added by greenlet for py3.13 with version 3.1.0