-
Notifications
You must be signed in to change notification settings - Fork 276
Control Volume 1D Scaler #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dallan-keylogic
wants to merge
12
commits into
IDAES:scaling_toolbox
Choose a base branch
from
dallan-keylogic:control_volume_1D_scaler
base: scaling_toolbox
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Control Volume 1D Scaler #1673
dallan-keylogic
wants to merge
12
commits into
IDAES:scaling_toolbox
from
dallan-keylogic:control_volume_1D_scaler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## scaling_toolbox #1673 +/- ##
===================================================
+ Coverage 77.09% 77.15% +0.05%
===================================================
Files 395 395
Lines 63182 63278 +96
Branches 10380 10418 +38
===================================================
+ Hits 48713 48824 +111
+ Misses 12021 12012 -9
+ Partials 2448 2442 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
BlockData
directly, not justIndexedBlocks
Summary/Motivation:
Adds a scaler for the
ControlVolume1D
.Changes proposed in this PR:
ControlVolume1D
flow_direction
property to allow public access to the_flow_direction
attribute.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: