Skip to content

Conversation

dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Sep 26, 2025

Fixes

  • Allows submodel scalers to be called on BlockData directly, not just IndexedBlocks

Summary/Motivation:

Adds a scaler for the ControlVolume1D.

Changes proposed in this PR:

  • Adds scaler for ControlVolume1D
  • Adds public flow_direction property to allow public access to the _flow_direction attribute.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 99.15966% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.15%. Comparing base (ca3c1fd) to head (321fae0).

Files with missing lines Patch % Lines
idaes/core/base/control_volume_base.py 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           scaling_toolbox    #1673      +/-   ##
===================================================
+ Coverage            77.09%   77.15%   +0.05%     
===================================================
  Files                  395      395              
  Lines                63182    63278      +96     
  Branches             10380    10418      +38     
===================================================
+ Hits                 48713    48824     +111     
+ Misses               12021    12012       -9     
+ Partials              2448     2442       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dallan-keylogic dallan-keylogic changed the title Control volume 1D Scaler Control Volume 1D Scaler Sep 29, 2025
@dallan-keylogic dallan-keylogic mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant