Fix Delete report - #352
Open
ibrahim-sall wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
A verified UX regression was introduced in CommunityToolbar where share error alerts no longer auto-dismiss because the alert duration parameter was removed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Cette PR vise à masquer les actions de suppression de signalements lorsque l’utilisateur n’a pas les droits requis (admin site ou admin “guichet”/communauté). Elle centralise la notion de rôle courant côté front (Zustand) et conditionne l’affichage des boutons “supprimer” dans les écrans de consultation et la table des signalements.
Changes:
- Ajout de
CommunityRole+ champadministratorsur l’utilisateur, et calcul du rôle courant dansuseUserStore. - Masquage des boutons/CTA de suppression des signalements dans la table et les vues/éditions via un
canDeletecentralisé. - Nettoyage mineur (suppression de
console.errordans le hook de suppression).
File summaries
| File | Description |
|---|---|
| src/store/useUserStore.ts | Stocke le rôle de l’utilisateur pour la communauté courante afin de piloter les droits UI. |
| src/pages/Carte.tsx | Alimente useUserStore.setUser avec communityId pour calculer le rôle. |
| src/hooks/reports/useDeleteReport.tsx | Nettoie la gestion d’erreur (suppression du log console). |
| src/features/reports/table/TableReport.tsx | Cache le bouton de suppression de la table si l’utilisateur n’est pas autorisé. |
| src/features/reports/ShowReport.tsx | Passe canDelete au composant d’actions (suppression/partage) côté fiche. |
| src/features/reports/ReportDrawer.tsx | Simplifie le calcul admin via user.administrator / role issu du store. |
| src/features/reports/forms/ReportForm.tsx | Cache l’action de suppression sur le formulaire d’édition si non-admin. |
| src/features/reports/DeleteShareReportComponent.tsx | Rend l’affichage du bouton de suppression dépendant d’un prop canDelete. |
| src/constants/user/types.tsx | Introduit CommunityRole et ajoute administrator aux types utilisateur. |
| src/constants/index.ts | Supprime des constantes de rôle devenues obsolètes. |
| src/components/Layout/MapCommunity/CommunityToolbar.tsx | Met à jour le calcul admin (et modifie la durée des alertes de partage). |
| src/components/AlertComponent.tsx | Ajuste le fallback de durée (mineur). |
| src/api/userData.ts | Mappe le champ administrator depuis l’API vers le type User. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ibrahim-sall
marked this pull request as ready for review
September 3, 2026 08:25
ibrahim-sall
force-pushed
the
fix/delete-report
branch
from
September 3, 2026 08:29
378fd94 to
2809116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Le but de cette PR est de masquer les boutons de suppression des signalements si l'utilisateur n'a pas les droits pour le faire. Un utilisateur ne peut supprimer son signalement, il doit être administrateur du site ou du guichet.
On masque les boutons sur la fiche de visualisation des signalements et sur le tableau principal.