Fix: Add contextual label to MainBar close button. #10244
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close button in the MainBar subsections was only labeled as "Close"
without indicating which specific subsection was being closed, causing
accessibility issues for screen reader users.
Changes:
- Modified mainbar.renderer.js to dynamically update both aria-label
and visible text of the close button when a slate is engaged
- Added toJS('close') in MainControls Renderer.php to expose the
translation key to JavaScript
- Close button now displays contextual information (e.g., "Close
Personal Workspace" instead of just "Close")
This fix improves WCAG 2.1 compliance by providing clear context about
which UI element will be affected by the close action.
Ticket 43949.
ZallaxDev
added
bugfix
kitchen sink
php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The close button in the MainBar subsections was only labeled as "Close" without indicating which specific subsection was being closed, causing accessibility issues for screen reader users.
Changes:
mainbar.renderer.jsto dynamically update both aria-label and visible text of the close button when a slate is engagedtoJS('close')in MainControlsRenderer.phpto expose the translation key to JavaScriptThis fix improves WCAG 2.1 compliance by providing clear context about which UI element will be affected by the close action.
Ticket 43949