-
Notifications
You must be signed in to change notification settings - Fork 390
Fix: Add answer status to question list for screen reader accessibility #10245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_10
Are you sure you want to change the base?
Conversation
…ty. Ticket 43952 This commit adds the answer status text to each question title in the question list, making it accessible to screen readers while maintaining the visual indicators. Changes: - Modified ilTestPlayerAbstractGUI::showSideList() to include answer status text in question titles - Uses existing language strings: tst_answer_status_answered and tst_answer_status_not_answered - Question titles now display as "Question Title (Answered)" or "Question Title (Not answered)". Ticket 43952
|
Hi @ZallaxDev Thanks for the PR! Just because I saw this coming by today: I do not think this is the right solution and I would need a lot of convincing to accept it for the test. This makes the experience for the majority of users (all looking at the page) worse by cluttering the screen with duplicate information to solve a problem for a smaller group (those having the screen read to them). I think the correct solution in this case would be to expand the interface of bulky links and bulky buttons by a way to set a "aria-label" on it and then set this as the value there. On a quick glance I do not believe the implementation is correct, either, but this would tackle later on. Just on a note to implement such an interface: It would be nice, if it would be built to enforce the requirement that the visible name is included in the accessible name . Thanks and best, |
|
Sorry, I just realized one more thing: This needs to be done a level up in the workflow. There it gets even more useful as it could be implemented by assigning a text representation to the status and the function for the buttons (in this case) and potentially also links could stay internal and wouldn't need to be on the interface. |
|
Thank you very much for the thorough review and detailed feedback. For us, your point makes a lot of sense: we understand that adding visible text may negatively affect the overall experience, and we agree that an aria-label–based solution would be more suitable and consistent with accessibility guidelines. We’ll mention @Annett7811 as the SIG Accessibility Leader and link this PR in the Mantis ticket so we can discuss it with a broader perspective and reach a well-agreed, robust solution together. Best regards, |
|
Hello! Thank you very much for the detailed feedback and the differentiated discussion on the topic of the status display in the question list. Best regards, |
|
Thanks for the feedback and discussion. Best regards, |
|
Hi everyone, I think it's totally fine that @ZallaxDev moves on and also that this issue was discussed here via GitHub. But I also want to point out: As far as I'm concerned, we have reinitiated the A11y-Squad exactly to have discussions like this. So afaic it would be absolutely fine to bring issues like this into the squad, discuss options and then decide for a way forward. Kind regards! |
This commit adds the answer status text to each question title in the question list, making it accessible to screen readers while maintaining the visual indicators.
Changes:
ilTestPlayerAbstractGUI::showSideList()to include answer status text in question titlestst_answer_status_answeredandtst_answer_status_not_answeredTicket 43952