Fix: Add accessible name to mainbar slate regions. #10246
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mainbar's expandable panels (slates), such as 'Tools' or 'Mail', were dynamically assigned `role="region"` but lacked an accessible name. This change fixes the issue by dynamically adding an accessible label to each slate region when it is expanded, using the visible text from its trigger button. Changes: - Modified the `additional_engage` function in `mainbar.renderer.js`. - When a slate is engaged, the script now finds the corresponding trigger button and extracts its visible text content (e.g., "Tools"). - This text is then used to populate the `aria-labelledby` attribute on the slate's `region` element, providing it with an accessible name. Ticket 43946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mainbar's expandable panels (slates), such as 'Tools' or 'Mail', were dynamically assigned
role="region"but lacked an accessible name.This change fixes the issue by dynamically adding an accessible label to each slate region when it is expanded, using the visible text from its trigger button.
Changes:
additional_engagefunction inmainbar.renderer.js.aria-labelledbyattribute on the slate'sregionelement, providing it with an accessible name.Ticket 43946