ECS: Implement Support for OpenID Connect #10252
Open
+291
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n course release label
lukas-heinrich
force-pushed
the
feature/trunk/ecs-oidc
branch
from
fca3cb0 to
883b592
Compare
|
@lukas-heinrich IMO I already fixed the "entry point" issue some days ago. Will you include the JF-approved composer dependency |
|
Hi @mjansenDatabay , I would prefer #9560 to be merged first. |
|
Hey @sKarki999 and @jeph864, I assigned this PR to you, as you are currently listed as Code Authority for Webservices. All the applied changes are within this module. We would highly appreciate your feedback on our changes. Best, |
|
Hey @sKarki999 and @jeph864, Sorry for the disturbance. I mixed up Authorities and removed you from the PR. Best, |
|
@lukas-heinrich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR proposes changes to the ECS component to integrate OIDC authentication. It implements the feature described in the wiki entry ECS Support for OpenID Connect enabling authentication on external LMS platforms using OpenID Connect.
During development, we encountered several issues that limited ECS functionality and complicated implementation. Below are the problems we addressed in this PR, along with their fixes. For better traceability, each fix is in a separate commit.
jumbojett/openid-connect-phpin trunkopenidconnect.phpentry_pointmethod instead ofilInitialisation::initILIAS(), similar toshib_login.php.1abbeab1ecs_part_settingsecs_part_settingstable stores information about imported ECS participants. Entries are created only when settings are first saved, not during object import. This causes errors such as missing array keys and course labels.508a5a65goto.php/crs/123, whileLegacyGotoHandlerexpectsgoto.php?target=crs_123.75d16219253d0012I look forward to comments and feedback on this PR. The changes were reviewed in an internal review process and approved by @thojou .
Best Regards
@lukas-heinrich