-
Notifications
You must be signed in to change notification settings - Fork 388
Cron: Move admin gui from Administration node to own node #10254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
9537bfd
to
6d4714c
Compare
components/ILIAS/Administration/classes/class.ilAdministrationSettingsFormHandler.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a small issue regarding the position in the admin menu. The rest of the changes in Administration look good to me.
components/ILIAS/Administration/GlobalScreen/classes/AdministrationMainBarProvider.php
Outdated
Show resolved
Hide resolved
6d4714c
to
3bf6ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving the menu entry. I checked out and tested again and found no problems. The code looks good to me.
3bf6ab8
to
754ff2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @lscharmer and @fneumann
This PR is part of the following Feature Requests: https://docu.ilias.de/go/wiki/wpage_8602_1357 and https://docu.ilias.de/go/wiki/wpage_8648_1357
This PR moves the administration settings for the
Cron
component from theAdministration
to theCron
component itself.Previously the settings where located at the admin node
System Settings and Maintenance
. This is moved to a new admin nodeCron
.Additionally the following is changed:
ilCronManager
class are replaced with corresponding calls toilObjCronGUI
(linking to the cron tab).classes
wasilCronManager
the folder is deleted.ilObjSystemFolderGUI::jumpToCronJobsObject
is removed and calls to it are replaced with direct links to theilObjCronGUI
.