[FIX] UI: reverse Component\JavaScriptBindable order.
#10257
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change JavaScript order from first-to-last to last-to-first * Ensures correct execution sequence
thibsy
force-pushed
the
fix/11/ui-javascript-bindable-order
branch
from
9908de6 to
16740bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @klees,
This has potential to cause some fallout, but IMO it's quite important. This
Currently, as a consumer of some
Component\JavaScriptBindable, it is not possible to provide JavaScript (on-load) code that uses the facility offered by the component. Why is that? This is due to the fact that our Renderers will also register said facility using the same mechanism, so it will be appended. This leads to the initialisation-code being rendered last.By reversing the order, consumers can now expect that a facility will be available and they can access it when providing their JavaScript code. This should probably be fixed with an improved mechanism altogether, but it will do for now.
Kind regards
@thibsy