Skip to content

Conversation

@fneumann
Copy link
Contributor

This PR is part of the feature request Unbundling of Admin Permissions

It moves the benchmarking functions from a tab of "General Settings" to a new node "Benchmarking" in the administration menu section "System Settings and Maintenance".

The GUI of "Benchmarking" has three tabs: "View", "Settings" and "Permissions".

  • "View" shows the last recorded database queries and has the subtabs "Chronological", "Slowest First", Sorted By SQL" and "Aggregated by Frst Table in SQL".
  • "Settings" needs write permission to be shown and has the form to activate a benchmark.
  • "Permissions" ist the standard tab for permision settings and needs the "edit_permissions" permission.

The code for benchmarking is moved from the Components "Database" and "SystemFolder" to a new component "Benchmark". The language variables are moved from the module "administration" to a new module "benchmark.

@fneumann fneumann requested review from chfsx and lscharmer October 17, 2025 15:34
@fneumann fneumann self-assigned this Oct 17, 2025
@fneumann fneumann added improvement php Pull requests that update Php code labels Oct 17, 2025
Copy link
Member

@chfsx chfsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM! Does this new component "benchmark" needs some approval of the JF/PM?

@fneumann
Copy link
Contributor Author

Thanks @chfsx. I'll clarify this with the PM today. Should we put this new component under the Authority of Database or would you like to get rid of it?

@chfsx
Copy link
Member

chfsx commented Oct 23, 2025

@fneumann thsnks for asking, you can clone the Database Authorities for the moment 👍

@fneumann fneumann force-pushed the dev11-move-benchmark branch from b743db7 to 6789a39 Compare October 24, 2025 14:50
@fneumann
Copy link
Contributor Author

Thx @chfsx @lscharmer for the reviews. I solved the merge conflict with the previous move of Cron and moved two lang vars from administration to benchmark.

@fneumann fneumann merged commit 4655139 into ILIAS-eLearning:trunk Oct 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants