-
Notifications
You must be signed in to change notification settings - Fork 388
11/user/feat user search #10259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11/user/feat user search #10259
Conversation
f95aa33
to
2540905
Compare
a631a67
to
7d3fef9
Compare
I tested this in the user interface and haven't detected any problems so far. |
Thank you all for the quick feedback! |
* @ilCtrl_Calls ilObjUserFolderGUI: ILIAS\User\Profile\Fields\ConfigurationGUI | ||
* @ilCtrl_Calls ilObjUserFolderGUI: ILIAS\User\Profile\Fields\CustomFieldsGUI | ||
* @ilCtrl_Calls ilObjUserFolderGUI: ILIAS\User\Profile\Prompt\SettingsGUI | ||
* @ilCtrl_Calls ilObjUserFolderGUI: ILIAS\User\Search\DefaultEndpointGUI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kergomard Class DefaultEndpointGUI
does not exist. Did you mean EndpointGUI
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @mjansenDatabay ! Yes, I did and I changed it now.
Hi @mjansenDatabay , @klees , @oliversamoila , hi all
This is a first draft for a UserAutocomplete-Input that can be retrieved from the public interface of
User
. The central crucial part of the implementation is in the folder components/ILIAS/User/src/Search/ the interface in components/ILIAS/User/src/PublicInterface.php .Currently the Field doesn't offer many options: You can just use it as is or you can add additional return values to it, but clearly this can be expanded.
The code for searching is a mix from the current implementation in the Mail and the RepositorySearch, but I will give this an additional check as the scope the search should cover is not easy to figure out, but I already wanted to share the state of things.
I've moved a few other things around to further clarify the structure.
If you are still willing to take a look at this: I'm a happy taker for feedback.
@klees : I also had to make a change in the Studyprogramme, please see: 8aa4b0f .
Thanks and best,
@kergomard