-
Notifications
You must be signed in to change notification settings - Fork 56
Earth in 2150: fixing constraints.yml part 5 #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
At my wits end, I now consulted with various AI tools and they say:
```
persist-credentials: false:
Ensures the credentials are correctly stored for subsequent Git operations, preventing authentication issues.
```
This is super annoying.. Now your suggestion wont even work because the problem is _specifically_ about the last github action step, so you cant really test it anywhere other than in the repo (or in a fork, which is a lot of churn).
I wonder, alternatively, if it would work to run it all in Ubuntu base image, and then
```
run: |
docker run --rm -v ${{ github.workspace }}:/workspace -w /workspace ubuntu:24.04 \
sh update-constraints.sh --in-docker
```
just in the Build constraints.txt step?
did the typical AI crap of not having the slightest understanding of the entire issue, seeing a few keywords and jumping at a conclusion. “PhD-level intelligence“ my arse! Looking at the last failed workflow, at the “create pull request” step: Look how all Git commands fail with a Compare with a previous non-failed workflow: See how the “determining the base and head repositories“ step did not fail here? So, the real problem here, which has nothing to do with credentials that are persisted or not, in that in our new workflow, for some reason
This looks like a much better solution. One that actually makes perfect sense, contrary to that AI crap. |
I am wondering though if `docker` is really available in `ubuntu-latest`, so I added a little check to fail early when it is the case. I removed `Install Required Packages` again as these are available in the ubuntu base image.
|
Next shot in the oven.. |
gouttegd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no longer sure of anything with this workflow 😅 , but this does look good to me.
|
It worked!!!! 🎉 |
|
Can’t help but noticing that in the end, it was the idea tentatively advanced by a human with a modest “I wonder if…” that was correct over the pseudo-solution confidently advanced by a LLM. Isn’t that interesting? |
|
Hhaha.. |
At my wits end, I now consulted with various AI tools and they say:
This is super annoying.. Now your suggestion (of testing locally) wont even work because the problem is specifically about the last github action step, so you cant really test it anywhere other than in the repo (or in a fork, which is a lot of churn).
I wonder, alternatively, if it would work to run it all in Ubuntu base image, and then
just in the Build constraints.txt step?