Fix location of generated context.json file. #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _dynamic_files.jinja2 template is creating the context.json file (list of prefixes used in the project) in src/config, but the standard Makefile is expecting to find that file in src/ontology/config. We amend the template to create the file at the location where the Makefile expects to find it. closes #1146
When building a SQLite product, we need to transform the JSON-formatted src/ontology/config/context.json file into a CSV variant, for the benefit of the semsql tool. Since the CSV file is a derived file that people are not supposed to edit (the source of truth is the JSON file), it is better to put that file in the temporary directory rather than the config directory.
If the project is not configured to use a context, then the target to produce .db files does not need to depend on $(CONTEXT_FILE_CSV). This still works because, without a context, the CONTEXT_FILE_CSV variable is never declared, so it expands to nothing. But it is cleaner to avoid relying on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that, when seeding, if the project is configured to use a context, the initial context file is created in
src/ontology/config, where the Makefile expects to find it.While we are at it, and related, we fix two small issues with the #1148 PR:
The
context.csvfile is a file that is derived from thecontext.jsonfile; as such, it should be written into thetmpdirectory, rather than into theconfigdirectory. Having such a file inconfigcould lead users to think they can (or are even expected to) edit that file, while they are only supposed to edit thecontext.jsonfile.The target to create a SQLite file should depend on the CSV context file only when the project is configured to use a context.