Always use GitHub-CLI for public release to GitHub. #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the 'github_curl' and 'github_python' methods of pushing a
release to GitHub -- these should no longer be needed now that
GitHub-CLI is available.
The 'public_release' ODK option should now be set to the name of the
hosting service for releases. For now, the only supported option is
'github' (which, in effect, is exactly as before). The older values
'github_curl' and 'github_python' are silently transformed into
'github'.
To accomodate for that change:
(1) GitHub-CLI (`gh`) is moved from ODKFull to ODKLite;
(2) conversely, PyGithub (which was only used for the `github_python`
method) is moved from ODKLite to ODKFull (it is not completely
*removed*, since people may have custom workflows that depend on
it).
closes #1296
matentzn
approved these changes
Oct 3, 2025
Contributor
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Wonderful removal of tech debt
gouttegd
added a commit
to INCATools/odkcore
that referenced
this pull request
Jan 1, 2026
This commit removes the `github_curl` and `github_python` methods of pushing a release to GitHub – these should no longer be needed now that GitHub-CLI is available. The public_release ODK option should now be set to the name of the hosting service for releases. For now, the only supported option is `github` (which, in effect, is exactly as before). The older values `github_curl` and `github_python` are silently transformed into `github`. This is a backport of INCATools/ontology-development-kit#1297, which happened in the original repository after ODK-Core had been started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
github_curlandgithub_pythonmethods of pushing a release to GitHub – these should no longer be needed now that GitHub-CLI is available.The
public_releaseODK option should now be set to the name of the hosting service for releases. For now, the only supported option isgithub(which, in effect, is exactly as before). The older valuesgithub_curlandgithub_pythonare silently transformed intogithub.To accommodate for that change:
(1) GitHub-CLI (
gh) is moved from ODKFull to ODKLite;(2) conversely, PyGithub (which was only used for the
github_pythonmethod) is moved from ODKLite to ODKFull (it is not completely removed, since people may have custom workflows that depend on it).closes #1296