Changing meshgrid to mgrid - fixing gdX, gdY and ext_x, ext_y for 2D kCS... #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2D reconstructions for different gdX and gdY look better indeed! However this pull request is not pep8 compliant (lines longer than 80 chars). It also breaks tests - which means these should be rethought, I believe they are not valid anymore. I think the old tests should be gradually dropped and more unit tests should be added. |
| lin_y = np.linspace(self.ymin, self.ymax, ny) | ||
| self.space_X, self.space_Y = np.meshgrid(lin_x, lin_y) | ||
| self.space_X, self.space_Y = np.mgrid[self.xmin:self.xmax:np.complex(0,nx), | ||
| self.ymin:self.ymax:np.complex(0,ny)] |
There was a problem hiding this comment.
To avoid long lines:
self.space_X, self.space_Y = np.mgrid[
self.xmin:self.xmax:np.complex(0,nx),
self.ymin:self.ymax:np.complex(0,ny)
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #6