Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 20, 2025

What this PR does / why we need it: This PR updates the library needed for the netcdf ingest functionality. The old copy of the library has become unavailable causing build errors. We have also seen warnings about bouncycastle being unavailable (it is now bouncy) - not clear if this update will fix that.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer: The change to the AbstractPidProvider is switching from a Strings class that was evidently coming from one of the libraries previously used in the

Suggestions on how to test this: If we can now build, the PR serves its purpose. Testing the netcdf ingest process (regression testing) should also be done.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers moved this to Ready for Review ⏩ in IQSS Dataverse Project Oct 20, 2025
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 20, 2025
@coveralls
Copy link

Coverage Status

coverage: 23.506%. remained the same
when pulling 7806c27 on GlobalDataverseCommunityConsortium:IQSS/11909-ucar_error
into a696b36 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test netcdf (we should, obviously) at all but I'm going to approve this. It has some nice cleanup: removing com.beust.jcommander.Strings.

I played around with but didn't commit the following test I added to PidUtilTest locally and I can see the String change working properly:

@Test
public void testGetProviders() throws IOException {
    JsonObject job = PidUtil.getProviders();
    System.out.println("providers " + JsonUtil.prettyPrint(job));
}

@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Oct 21, 2025
providerSpecification.add("excludedSet", String.join(",", excludedSet));
return providerSpecification.build();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is failing but I think it's unrelated to this PR. I just kicked off another run: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11910/3/

@pdurbin
Copy link
Member

pdurbin commented Oct 22, 2025

The old copy of the library has become unavailable causing build errors.

The old copy is apparently back or at least we're able to build fine now without this PR. See #11919, for example. As discussed at standup we closed the following "can't build" issue now that we can build:

@cmbz cmbz added FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) labels Oct 22, 2025
@ofahimIQSS ofahimIQSS self-assigned this Oct 30, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Oct 30, 2025
@cmbz cmbz assigned pdurbin and unassigned ofahimIQSS Nov 5, 2025
@pdurbin
Copy link
Member

pdurbin commented Nov 5, 2025

@pdurbin pdurbin merged commit f77bb8c into IQSS:develop Nov 5, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 5, 2025
@pdurbin pdurbin deleted the IQSS/11909-ucar_error branch November 5, 2025 20:56
@pdurbin pdurbin removed their assignment Nov 5, 2025
@pdurbin pdurbin added this to the 6.9 milestone Nov 5, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants